[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 2/3] install_script: add get_config_param function



On Mon, Oct 1, 2012 at 3:46 AM, Fabiano Fidêncio <fabiano fidencio org> wrote:
> Return, if exists, the sought OsinfoInstallConfigParam from an
> OsinfoInstallScript. Otherwise, NULL is returned.

Looks good otherwise but the usual convention for returning objects is
to return a new reference, not a const.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]