[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo 1/5] Add translation framework



Hey,

On Fri, Oct 19, 2012 at 06:49:56AM +0300, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
> diff --git a/configure.ac b/configure.ac
> index f021fb6..6f91b96 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -12,6 +12,17 @@ LIBOSINFO_COMPILE_WARNINGS
>  GNOME_MAINTAINER_MODE_DEFINES
>  AM_MAINTAINER_MODE([enable])
>  
> +# Initialize libtool
> +LT_PREREQ([2.2])
> +LT_INIT([disable-static])

Is it mandatory to use intltool? configure.ac already calls
AC_PROG_LIBTOOL, which according to
https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html is a
"deprecated name for older versions of this [LT_INIT] macro"
We can switch to the newer version if needed, but the call to
AC_PROG_LIBTOOL should be removed, and this would be better done as a
separate patch.


> diff --git a/po/POTFILES.in b/po/POTFILES.in
> new file mode 100644
> index 0000000..88dfb7e
> --- /dev/null
> +++ b/po/POTFILES.in
> @@ -0,0 +1,29 @@
> +osinfo/osinfo_db.c
> +osinfo/osinfo_deployment.c
> +osinfo/osinfo_deploymentlist.c
> +osinfo/osinfo_device.c
> +osinfo/osinfo_devicelink.c
> +osinfo/osinfo_devicelinkfilter.c
> +osinfo/osinfo_devicelinklist.c
> +osinfo/osinfo_devicelist.c
> +osinfo/osinfo_entity.c
> +osinfo/osinfo_filter.c
> +osinfo/osinfo_install_config.c
> +osinfo/osinfo_install_config_param.c
> +osinfo/osinfo_install_script.c
> +osinfo/osinfo_install_scriptlist.c
> +osinfo/osinfo_list.c
> +osinfo/osinfo_loader.c
> +osinfo/osinfo_media.c
> +osinfo/osinfo_medialist.c
> +osinfo/osinfo_os.c
> +osinfo/osinfo_oslist.c
> +osinfo/osinfo_platform.c
> +osinfo/osinfo_platformlist.c
> +osinfo/osinfo_product.c
> +osinfo/osinfo_productfilter.c
> +osinfo/osinfo_productlist.c
> +osinfo/osinfo_resources.c
> +osinfo/osinfo_resourceslist.c
> +osinfo/osinfo_tree.c
> +osinfo/osinfo_treelist.c

Why do you add all these files to POTFILES.in? They don't have strings to
translate, and intltool-update -M does not complain when it's empty

Christophe

Attachment: pgpswiAguJPhV.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]