[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo 2/5] Also translate database strings



On Fri, Oct 19, 2012 at 5:21 PM, Eric Blake <eblake redhat com> wrote:
> On 10/19/2012 03:56 AM, Michal Privoznik wrote:
>> On 19.10.2012 05:49, Zeeshan Ali (Khattak) wrote:
>>> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
>>>
>
>>> +
>>> + INTLTOOL_XML_RULE@
>>
>> This is causing 'make syntax-check' to fail. However, I am not sure how to avoid that other than adding rule to cfg.mk:
>>
>> exclude_file_name_regexp--sc_makefile_at_at_check = ^(data/devices/Makefile.am|data/hypervisors/Makefile.am|data/oses/Makefile.am)
>
> You don't need an exclude rule - that's too heavy of a hammer as it
> prevents all other tests for invalid use of @FOO@ in Makefile.am.  Does
> $(INTLTOOL_XML_RULE) work?

Nope. :(

>  If so, use that.  If not, then add this
> instead to your cfg.mk, which exempts just the one pattern, rather than
> the entire file:
>
> _makefile_at_at_check_exceptions = INTLTOOL_XML_RULE

I used this one. `make syntax-check` still fails though but for
another issue AFAICT.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]