[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH] use brackets for shell variables



On 10/21/2012 10:05 AM, Christian Hesse wrote:
> ---

> +++ b/tests/test-baremetal.sh
> @@ -17,18 +17,18 @@
>  
>  root=tests/baremetal
>  
> -output="$(./virt-what --test-root=$root 2>&1)"
> +output="$(./virt-what --test-root=${root} 2>&1)"

Why?  This is cosmetic only, and serves only to require additional
typing.  I don't see any correctness changes in this patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]