[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer] Fail if neither vnc nor spice is detected



On Mon, Oct 22, 2012 at 08:41:06PM +0200, Guido Günther wrote:
> Since the viewer makes little sense otherwise.
> ---
>  configure.ac |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index e7ddd3e..d5feb0f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -192,6 +192,10 @@ if test "x$enable_plugin" = "xyes"; then
>  fi
>  AM_CONDITIONAL(ENABLE_PLUGIN, [test "x$enable_plugin" = "xyes"])
>  
> +if test "x$have_gtk_vnc" != "xyes" -a "x$have_gtk_spice" != "xyes"; then

IIRC
if test "x$have_gtk_vnc" != "xyes" && test "x$have_gtk_spice" != "xyes"; then
is better as it is more portable.
Apart from this, ACK

Christophe


> +    AC_MSG_ERROR([At least one of spice or vnc must be used])
> +fi
> +
>  AC_OUTPUT([
>      Makefile
>      data/Makefile
> -- 
> 1.7.10.4
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list redhat com
> https://www.redhat.com/mailman/listinfo/virt-tools-list

Attachment: pgpQH8chkUPkY.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]