[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer] Don't fail early if virDomainOpenGraphics fails



On Mon, Oct 22, 2012 at 10:00:41PM +0200, Guido Günther wrote:
> virt_viewer_app_open_connection invokes virDomainOpenGraphics which only works
> for local connections. Returning after this failure makes us never reach the
> ssh part so this unbreaks connections tunneled over ssh.

It seems virt_viewer_app_channel_open is doing some stuff related to ssh
after calling _open_connection as well, should this also be patched?
And one of the previous patches, you changed error-reporting in
_open_connection, but now you remove checks for these errors, so I guess I
don't really understand all of that code :(

Christophe

> ---
>  src/virt-viewer-app.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> index 7dcc4c1..34dcdde 100644
> --- a/src/virt-viewer-app.c
> +++ b/src/virt-viewer-app.c
> @@ -821,8 +821,7 @@ virt_viewer_app_default_activate(VirtViewerApp *self)
>      VirtViewerAppPrivate *priv = self->priv;
>      int fd = -1;
>  
> -    if (!virt_viewer_app_open_connection(self, &fd))
> -        return -1;
> +    virt_viewer_app_open_connection(self, &fd);
>  
>      DEBUG_LOG("After open connection callback fd=%d", fd);
>  
> -- 
> 1.7.10.4
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list redhat com
> https://www.redhat.com/mailman/listinfo/virt-tools-list

Attachment: pgpOyhe1HnwCo.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]