[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo v6 3/4] maint.mk: Resync from gnulib.



On 10/29/2012 03:15 PM, Zeeshan Ali (Khattak) wrote:

>> https://lists.gnu.org/archive/html/bug-gnulib/2012-10/msg00095.html
>> -         grep -E -l '$(translation-markers)' $$files                   \
>> +         grep -E -l '$(_gl_translatable_string_re)' $$files            \
>>
>> It might be worth holding off 24 hours until Jim actually commits that
>> gnulib change,
> 
> Oops, I already pushed after Michal's ACK. Should have waited for your
> ACK too as I asked you to look at the patches earlier.

No problem - what you committed accurately matches today's gnulib.git.

> 
>> and then synchronize to that version of maint.mk, rather
>> than landing on a version of maint.mk from a 3-day window, and where the
>> next time anyone updates maint.mk they get a surprise if they aren't
>> aware of the need to rename the cfg.mk variable.
> 
> We'll get an error from `make syntax-check` when that happens, right?

Yep.  My only concern is that if we don't track gnulib right away, then
3 months down the road the next time someone does decide to resync to
gnulib, they won't have any idea why.  It's always better to fix
potential latent problems when they are fresh on your mind :)

So I'll propose a followup patch once Jim's gnulib patch actually lands.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]