[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-manager][PATCH] Fix --test-first-run



On 10/30/2012 09:22 AM, Michal Privoznik wrote:
> One of previous patches (96ce9ac0b125) invented this feature. However,
> in options object it is called testfirstrun not test_first_run.
> This produces a runtime error.
> ---
>  src/virt-manager.py.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/virt-manager.py.in b/src/virt-manager.py.in
> index 8d09b28..f314502 100755
> --- a/src/virt-manager.py.in
> +++ b/src/virt-manager.py.in
> @@ -334,7 +334,7 @@ def main():
>      import virtManager.config
>      import virtManager.util
>      config = virtManager.config.vmmConfig(appname, appversion, ui_dir,
> -                                          options.test_first_run)
> +                                          options.testfirstrun)
>      virtManager.util.running_config = config
>      config.default_qemu_user = default_qemu_user
>      config.rhel6_defaults = rhel_enable_unsupported_opts
> 

Whoops, I hit that issue too, but I must have fixed it in virt-manager.py by
mistake and never committed the actual change.

Thanks for the patch, added you to AUTHORS and pushed now.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]