[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo v3 1/3] Add private headers



On Wed, Oct 31, 2012 at 12:41 AM, Eric Blake <eblake redhat com> wrote:
> On 10/30/2012 03:08 PM, Zeeshan Ali (Khattak) wrote:
>> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
>>
>> These are meant for including headers needed by all/many .c files.
>> ---
>>  cfg.mk                               |  6 ++++--
>
>> +++ b/cfg.mk
>> @@ -113,6 +113,8 @@ sc_copyright_format:
>>  # We don't use this feature of maint.mk.
>>  prev_version_file = /dev/null
>>
>> +config_h_header = "osinfo_priv.h"
>> +
>
> Good, although I'd group it differently, under the comment:
>
> # Tweak how some of the syntax check rules work
>
>
>>  # Give credit where due:
>>  # Ensure that each commit author email address (possibly mapped via
>>  # git log's .mailmap) appears in our AUTHORS file.
>> @@ -134,8 +136,8 @@ exclude_file_name_regexp--sc_preprocessor_indentation = ^*/*.[ch]
>>
>>  exclude_file_name_regexp--sc_prohibit_strcmp = ^*/*.[ch]
>>
>> -exclude_file_name_regexp--sc_require_config_h = python/libvirt-glib.c
>> -exclude_file_name_regexp--sc_require_config_h_first = python/libvirt-glib.c
>> +exclude_file_name_regexp--sc_require_osinfo_priv_h = python/libvirt-glib.c
>> +exclude_file_name_regexp--sc_require_osinfo_priv_h_first = python/libvirt-glib.c
>
> Not good.  You aren't renaming the maint.mk rule, so this hunk is
> spurious leftovers from the earlier attempt.

Ouch, indeed. I didn't know any of that patch got applied to the tree.


-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]