[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [libosinfo v3 3/3] Steal libvirt magic for picking translation files



On Tue, Oct 30, 2012 at 11:08:53PM +0200, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
> 
> This is needed since we don't want to have a static LINGUAS file.

Why don't we want that? Not that I disagree, just that you are stating
something as obvious, while it is not to me. Won't translators get confused
by the missing LINGUAS file? or will we be committing translations
ourselves anyway?

Apart from that, patch looks good to me.

Christophe

> ---
>  configure.ac | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 8741756..e3e4dd5 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -21,6 +21,8 @@ AC_DEFINE_UNQUOTED([GETTEXT_PACKAGE],["$GETTEXT_PACKAGE"],[The name of the gette
>  AM_GNU_GETTEXT([external])
>  AM_GNU_GETTEXT_VERSION([0.17])
>  
> +ALL_LINGUAS=`cd "$srcdir/po" > /dev/null && ls *.po | sed 's+\.po$++'`
> +
>  # Autoconf 2.61a.99 and earlier don't support linking a file only
>  # in VPATH builds.  But since GNUmakefile is for maintainer use
>  # only, it does not matter if we skip the link with older autoconf.
> -- 
> 1.7.12.1
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list redhat com
> https://www.redhat.com/mailman/listinfo/virt-tools-list

Attachment: pgpmW5FqqCRGe.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]