[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [python-virtinst PATCH] Don't support sparse logical volumes



On 04/02/2013 07:51 AM, Martin Kletzander wrote:
> Sparse logical volumes are supported by libvirt, but only in case the
> user takes care of the reallocation, which is not what virt-install
> and virt-manager users want.  This patch defaults the logical volumes
> to non-sparse ones and makes sure allocation is always equal to
> capacity for such volumes.
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>


Thanks Martin, pushed now. But this breaks a couple unit tests, please fix
them with a follow up patch.

...actually I think I pushed this a bit too prematurely. Since sparse used to
'work' with older libvirt (really libvirt just ignored allocation), rather
than explicitly error we should just logging.warn("sparse not supported,
settiing alloc=cap") and do as such. Please send a follow up patch to fix.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]