[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 0/4] v2 virt-manager IPv6 support



On 03/29/2013 02:38 PM, Gene Czarcinski wrote:
> These patches add support for IPv6 to virt-manager.
> 
> The first patch updates the Virtual Networks gui to support
> IPv6.  This includes replacing the use of IPy with ipaddr
> in network.py, host.py, and createnet.py.
> 
> New network defines are added to tests.  Also, the bug causing
> exceptions when deleting a network has been fixed.
> 
> The secon patch updates the gui create net wizard (vmm-create-net.ui
> and createnet.py).  Extensive changes were made in the gui.  The
> dhcp page was folded into the IPv4 page and a new IPv6 page has been
> added which include the network address specification as well asThanks Gene, gr
> the addresses for DHCPv6.  The Forwarding Page has been
> changed to the Miscellaneous Settings Page with added specifications.
> 
> THe best way to understand the changes is to use glade-3 to
> display the two .ui files and to actually run the updated
> virt-manager.
> 
> I have included patch three since it updates the tui python code to use ipaddr
> instead of IPy.  This worked under RELEASE-0.9.4-1 but the gtk3.2 branch of the
> virt-manager-tui code was broken even before applying this patch.  I understand
> that some consideration is being given to deleting virt-manager-tui and
> that would certainly be my vote.
> 
> Patch four updates the rpm spec.
> 
> Note:  To the best of my knowledge, the following is 
> an accurate summary of forwarding/routing:
> 
> Isolated-1: *no* address specified
>         IPv4   - internal routing between guests is enabled.
>         IPv6   - internal routing between guests is enabled only if ipv6='yes' is specified
> 
> Isolated-2: address specified but no <forward>
>         IPv4   - internal routing between guests and between guests and virtualization host
>         IPv6   - internal routing between guests and between guests and virtualization host
>         Also   - dnsmasq used for DNS service for each address specified
>         Option - dhcp for either or both addresses
> 
> Routed-1 - address specified, <forward> with NAT
>         IPv4   - forwarded with Network Address Translation
>         IPv6   - forward-routed with no restrictions
>         Also   - dnsmasq used for DNS service for each address specified
>         Option - dhcp for either or both addresses
> 
> Routed-2 - address specified, <forward> with route specified
>         IPv4   - forward-routed with no restrictions
>         IPv6   - forward-routed with no restrictions
>         Also   - dnsmasq used for DNS service for each address specified
>         Option - dhcp for either or both addresses 
> .
> Gene Czarcinski (4):
>   IPv6 support v2: update gui python and ui
>   IPv6 support v2: update the create network wizard
>   IPv6 support v2: update the virt-manager-tui
>   IPv6 support v2: update rpm spec file
> 

Great work Gene! Thanks for stepping up and working on this. I've pushed this
series now.

Admittedly I didn't give it a thorough review, but the code looks fine and it
didn't fall over in my testing, which is good enough at this stage figuring
that the rest of the tree is in flux.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]