[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 1/2] update autobuild.sh so it works



On 04/04/2013 12:49 PM, Daniel P. Berrange wrote:
On Thu, Apr 04, 2013 at 12:41:30PM -0400, Gene Czarcinski wrote:
There a some problems with autobuild.sh and this patch addresses
them:

1. Some of the tests fail so temporarily comment out
"prython setup.py test" until things are fixed so the tests
run correctly.  At that time, this should be uncommented.

2. "python setup.py install" needs to use --root= instead
of --prefix=

3. For the rpmbuild, use dist/*tar.gz instead of *.tar.gz

4. "python setup.py build" modifies the git tracked/managed
file po/virt-manager.pot so that you end of with uncommitted
changes.  To correct this: use the sdist created tarball,
expand it into a local/unmangerd directory and run build,
test, and install out of this directory.
Actually the right fix there is to just remove virt-manager.pot
from GIT entirely. GIT shouldn't be used to track any files
which are purely auto-generated, as the .pot file is. Only the
.po files need to be in GIT

I was not sure whether it should be tracked or not since it has been tracked back to 2006 when it was added.

Might be worth a little time by someone much more knowledgeable than I am to see if there are any other files which should not be tracked.

I will redo the patch since some fixes are still needed. The patch will also git-rm and add the filename to .gitignore.

Gene


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]