[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 1/2] update autobuild.sh so it works



On Thu, Apr 04, 2013 at 03:15:38PM -0400, Cole Robinson wrote:
> On 04/04/2013 12:49 PM, Daniel P. Berrange wrote:
> > On Thu, Apr 04, 2013 at 12:41:30PM -0400, Gene Czarcinski wrote:
> >> There a some problems with autobuild.sh and this patch addresses
> >> them:
> >>
> >> 1. Some of the tests fail so temporarily comment out
> >> "prython setup.py test" until things are fixed so the tests
> >> run correctly.  At that time, this should be uncommented.
> >>
> >> 2. "python setup.py install" needs to use --root= instead
> >> of --prefix=
> >>
> >> 3. For the rpmbuild, use dist/*tar.gz instead of *.tar.gz
> >>
> >> 4. "python setup.py build" modifies the git tracked/managed
> >> file po/virt-manager.pot so that you end of with uncommitted
> >> changes.  To correct this: use the sdist created tarball,
> >> expand it into a local/unmangerd directory and run build,
> >> test, and install out of this directory.
> > 
> > Actually the right fix there is to just remove virt-manager.pot
> > from GIT entirely. GIT shouldn't be used to track any files
> > which are purely auto-generated, as the .pot file is. Only the
> > .po files need to be in GIT
> > 
> 
> Transifex requires the pot file to be in tree at least, there's a bit about it
> here:

Ah, well i guess it depends how you use transifex :-) For other projects
I don't ever let Transifex have any repo access. I just use 'tx push' to
send the updated pot file to transifex when required, and 'tx pull' to
bring down the .po's later.


Back to the original issue - autobuild.sh causing virt-manager.pot to
change, that's not an issue for autobuild, since it always does a
git reset before running autobuild.sh. It is only an issue with people
running autobuild.sh manually, and  don't think that's worth worrying
about. If the .pot changes, then should ought to be committing the update
to GIT so transifex can pull it.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]