[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH-v5.5 5/5] virt-manager version-id changes



On Thu, Apr 11, 2013 at 02:01:39PM -0400, Gene Czarcinski wrote:
> >I think this can be solved by adding an option to sdist or rpm subcommands
> >that allows temporarily overwriting __version__. Then all the __version__
> >building logic can be moved to an external script, which just passes the value
> >to setup.py
> Great minds and all that stuff.
> 
> This is more or less the approach I thought to look into.  Something
> where the default is as it now is but with some means of specifying
> a "user version" override when sdist is run.

I haven't followed the conversation closely, hopefully all of this was not
discussed yet ;) The solution you are aluding to sounds a lot like the
git-version-gen script which is used in several projects, see
http://stuff.mit.edu/afs/athena/astaff/project/opssrc/cups/autoconf-2.65/build-aux/git-version-gen
for example.
This is the solution Eric mentioned at the beginning of this thread
https://www.redhat.com/archives/virt-tools-list/2013-April/msg00106.html

The way the versioning is done is:
- if there's a 'vXXXX' tag pointing at the current HEAD, then version is
  XXX
- else version is XXXX.z-hash where XXXX is the most recent tag in the
  current branch, z is the number of commits made since that tag, and
  hash is a short hash for HEAD

This gives you a version number that always increases, even for snapshots
from git.

Christophe

Attachment: pgpZSj7mN408k.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]