[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH-v6.1 4/5] add option for snapshot-id suffix to __version__



On 04/17/2013 03:36 PM, Cole Robinson wrote:
Thanks Gene, I applied this series.

There's still a little weirdness here though, subclassing sdist_auto but
calling sdist.finalize_options, etc. I pushed an addon commit that fixed that
up, and fixed up some 'python setup.py pylint' output as well. rpm building
with and without --snapshot seem to work fine, but please confirm.
It is quite possible that I don't understand all of the class/subclass inheriting. Since sdist_auto did not have a finalize_options but sdist did ... leaning all the time.

I have a "large" updating coming "real soon now" which does more updating for networking. I have a lot of updates to createnet.py. I saw the updates for pylint but need some guidance as to when "ignore = src" should be added and when it should not ... I am not that well versed in pylint. From the current update, "ignore = src" seems to be added only to the methods handling the check-box changes.

Gene


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]