[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 1/3] checking libvirt version and UPDATE_CPU flag



On 04/18/2013 12:40 AM, Cole Robinson wrote:
On 04/16/2013 07:02 AM, Guannan Ren wrote:

+ SUPPORT_DOMAIN_CPU_HOST_MODEL : {
+        "version" : 9010,
+   },
+
+   SUPPORT_DOMAIN_XML_UPDATE_CPU : {
+        "function" : "virDomain.XMLDesc",
+        "args" : (),
+        "flag" : "VIR_DOMAIN_XML_UPDATE_CPU",
+   },
+
# Pool checks
      # This can't ever require a pool object for back compat reasons


Actually since the UPDATE_CPU flag is handled in generic libvirt code, we
don't need to test it since it should be provided by all drivers, or none at
all. I would only add the HOST_MODEL support check, but have it check the
earliest that supports both host-model _and_ UPDATE_CPU


   UPDATE_CPU flag exists after v0.8.0, so libvirt that supports HOST_MODEL should
   support UPDATE_CPU, the earliest version we are going to check is v0.9.10.

   Guannan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]