[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[virt-tools-list] [PATCH v3 0/3]bug fix about attaching usb devices from same vendors



v2 to v3
  add is_dup flag for VirtualHostDeviceUSB
  make virt-install use is_dup when --host-devices use bus.addr format
  add a domain pre-start hook to check duplicate USB devices
  
v1 to v2
  squashed original 1/2 into 2/2
  fixed a testcase break
  moved get_nodedev_numbers() to addhardware.py
  Add a UI fix patch as current [PATCH 1/2]

Resolve: https://bugzilla.redhat.com/show_bug.cgi?id=820303

When there are multiple usb devices being attached with same
vendorId and productId, virt-manager failed to distinguish
them.
The patchset makes virt-manager use <address> to distingush
multiple usb devices as follows:

  <hostdev mode='subsystem' type='usb' managed='yes'>
    <source>
      <vendor id="0x15e1"/>
      <product id="0x2007"/>
      <address bus='5' device='19'/>
    </source>
  </hostdev>

When there is unique usb device, the xml is like:
  <hostdev mode="subsystem" type="usb" managed="yes">
    <source>
      <vendor id="0x15e1"/>
      <product id="0x2007"/>
    </source>
  </hostdev>

Guannan Ren(3)
 [PATCH v3 1/3] addhardware: differentiate duplicate usb devices by bus/addr
 [PATCH 2/3] virtinst: set is_dup to true when --host-device uses bus.addr
 [PATCH 3/3] domain: add pre-start hook to check duplicate multiple node devices

 tests/nodedev-xml/devxml/usbdev2.xml |  2 ++
 tests/nodedev.py                     | 10 +++-------
 virtManager/addhardware.py           | 23 ++++++++++++++++++++---
 virtManager/connection.py            | 15 +++++++++++++++
 virtManager/domain.py                | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 virtinst/NodeDeviceParser.py         | 17 +++++++++++++----
 virtinst/VirtualHostDevice.py        | 13 ++++++++-----
 7 files changed, 116 insertions(+), 19 deletions(-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]