[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[virt-tools-list] [virt-manager][PATCH ] Fix profile runcall.



From: Leonardo Garcia <lagarcia br ibm com>

---

Running "virt-manager --profile=foo" I got the following error:

[Mon, 12 Aug 2013 19:25:09 virt-manager 3147] DEBUG (virt-manager:49) Error starting virt-manager: run() takes exactly 2 arguments (1 given)
Traceback (most recent call last):
  File "./virt-manager", line 301, in <module>
    main()
  File "./virt-manager", line 293, in main
    prof.runcall(engine.application.run)
  File "/usr/lib64/python2.7/hotshot/__init__.py", line 78, in runcall
    return self._prof.runcall(func, args, kw)
  File "/usr/lib64/python2.7/site-packages/gi/types.py", line 113, in function
    return info.invoke(*args, **kwargs)
TypeError: run() takes exactly 2 arguments (1 given)
Traceback (most recent call last):
  File "./virt-manager", line 301, in <module>
    main()
  File "./virt-manager", line 293, in main
    prof.runcall(engine.application.run)
  File "/usr/lib64/python2.7/hotshot/__init__.py", line 78, in runcall
    return self._prof.runcall(func, args, kw)
  File "/usr/lib64/python2.7/site-packages/gi/types.py", line 113, in function
    return info.invoke(*args, **kwargs)
TypeError: run() takes exactly 2 arguments (1 given)

Should this be fixed or should I submit a patch removing the --profile option as it seems nobody is using it?


 virt-manager |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/virt-manager b/virt-manager
index cc506fb..1100d23 100755
--- a/virt-manager
+++ b/virt-manager
@@ -290,7 +290,7 @@ def main():
     if options.profile is not None:
         import hotshot
         prof = hotshot.Profile(options.profile)
-        prof.runcall(engine.application.run)
+        prof.runcall(engine.application.run, None)
         prof.close()
     else:
         engine.application.run(None)
-- 
1.7.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]