[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 1/3] virt-manager: do not delete tabs while destroying the details window



On 08/09/2013 08:18 AM, Giuseppe Scrivano wrote:
> _close_serial_tab triggers the switch-page event and that can provoke a
> refresh of the window.  This causes an error everytime the details window
> is pointing to a domain that was just deleted.
> 
> Solves: https://bugzilla.redhat.com/show_bug.cgi?id=985291
> 
> Signed-off-by: Giuseppe Scrivano <gscrivan redhat com>
> ---
>  virtManager/details.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virtManager/details.py b/virtManager/details.py
> index afb7945..2f7e7d4 100644
> --- a/virtManager/details.py
> +++ b/virtManager/details.py
> @@ -567,7 +567,7 @@ class vmmDetails(vmmGObjectUI):
>          self.media_choosers = {}
>  
>          for serial in self.serial_tabs:
> -            self._close_serial_tab(serial)
> +            serial.cleanup()
>  
>          self.console.cleanup()
>          self.console = None
> 

Thanks, pushed now.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]