[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 1/5] virt-manager: refresh the storage pool browse list when updated



On 08/13/2013 09:30 AM, Eric Blake wrote:
> On 08/13/2013 06:26 AM, Giuseppe Scrivano wrote:
>> The commit b044dd renamed vmmStoragePool.uuid to vmmStoragePool._uuid,
>> causing this error:
> 
> When sending a series, it helps to use 'git send-email --cover-letter'
> to add a 0/5 header describing the series as a whole.
> 

Agreed, though in this case since the series was more a random collection of
bug fixes, it would make more sense to have each patch be a top level [PATCH].

>>
>> Traceback (most recent call last):
>>   File "virtManager/storagebrowse.py", line 280, in refresh_current_pool
>>     self.refresh_storage_pool(None, cp.get_uuid())
>>   File "virtManager/storagebrowse.py", line 243, in refresh_storage_pool
>>     if curpool.uuid != uuid:
>> AttributeError: 'vmmStoragePool' object has no attribute 'uuid'
> 
> The subject line of this patch doesn't match the commit message contents.
> 

I tweaked the first patch subject and pushed the series.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]