[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer 04/12] kiosk: use less verbose window/display status



On Thu, Aug 15, 2013 at 4:37 PM, Daniel P. Berrange <berrange redhat com> wrote:
> On Mon, Jul 15, 2013 at 09:36:11PM +0200, Marc-André Lureau wrote:
>> We want extra windows to remain blank after connection
>
> Why exactly ?
>

For example, if guest has a single monitor, and client has more, we
don't want extra client monitors to say "Connected to graphic server"
in kiosk mode. Instead, we leave them empty/black.

>> ---
>>  src/virt-viewer-app.c | 9 +++++++--
>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
>> index 5456b8d..a38841c 100644
>> --- a/src/virt-viewer-app.c
>> +++ b/src/virt-viewer-app.c
>> @@ -695,7 +695,8 @@ display_show_hint(VirtViewerDisplay *display,
>>          if (win != self->priv->main_window &&
>>              g_getenv("VIRT_VIEWER_HIDE"))
>>              virt_viewer_window_hide(win);
>> -        virt_viewer_notebook_show_status(nb, _("Waiting for display %d..."), nth + 1);
>> +        if (!self->priv->kiosk)
>> +            virt_viewer_notebook_show_status(nb, _("Waiting for display %d..."), nth + 1);
>>      }
>>      virt_viewer_app_update_menu_displays(self);
>>
>> @@ -1150,7 +1151,11 @@ virt_viewer_app_connected(VirtViewerSession *session G_GNUC_UNUSED,
>>      VirtViewerAppPrivate *priv = self->priv;
>>
>>      priv->connected = TRUE;
>> -    virt_viewer_app_show_status(self, _("Connected to graphic server"));
>> +
>> +    if (self->priv->kiosk)
>> +        virt_viewer_app_show_status(self, "");
>> +    else
>> +        virt_viewer_app_show_status(self, _("Connected to graphic server"));
>>  }
>>
>
> Daniel
> --
> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-             http://virt-manager.org :|
> |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|



-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]