[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer 08/12] kiosk: don't quit on disconnection



We want to keep the app alive, in fullscreen, by all means, Even if
the remote session ended for example. Ie, we want to prevent the app
from quiting itself.

On Thu, Aug 15, 2013 at 4:44 PM, Daniel P. Berrange <berrange redhat com> wrote:
> On Mon, Jul 15, 2013 at 09:36:15PM +0200, Marc-André Lureau wrote:
>> ---
>>  src/virt-viewer-app.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
>> index d5acd2c..ffcf451 100644
>> --- a/src/virt-viewer-app.c
>> +++ b/src/virt-viewer-app.c
>> @@ -1105,7 +1105,8 @@ virt_viewer_app_default_deactivated(VirtViewerApp *self, gboolean connect_error)
>>                                priv->guest_name);
>>      }
>>
>> -    gtk_main_quit();
>> +    if (!self->priv->kiosk)
>> +        gtk_main_quit();
>
> Why don't we want to quit ?  What can the app do when it has disconnected if
> it doesn't quit ?  Again it would be nice to have the rationale / intended
> behaviour for the change explained in the commit message.
>
> Daniel
> --
> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-             http://virt-manager.org :|
> |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|



-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]