[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-manager][PATCH ] Fix profile runcall.



On 08/16/2013 04:15 AM, TingtingZheng wrote:
On 08/15/2013 09:13 AM, Cole Robinson wrote:
On 08/12/2013 06:33 PM, Leonardo Garcia wrote:
From: Leonardo Garcia<lagarcia br ibm com>

Thanks, pushed.

---

Running "virt-manager --profile=foo" I got the following error:

[Mon, 12 Aug 2013 19:25:09 virt-manager 3147] DEBUG (virt-manager:49) Error starting virt-manager: run() takes exactly 2 arguments (1 given)
Traceback (most recent call last):
   File "./virt-manager", line 301, in<module>
     main()
   File "./virt-manager", line 293, in main
     prof.runcall(engine.application.run)
   File "/usr/lib64/python2.7/hotshot/__init__.py", line 78, in runcall
     return self._prof.runcall(func, args, kw)
File "/usr/lib64/python2.7/site-packages/gi/types.py", line 113, in function
     return info.invoke(*args, **kwargs)
TypeError: run() takes exactly 2 arguments (1 given)
Traceback (most recent call last):
   File "./virt-manager", line 301, in<module>
     main()
   File "./virt-manager", line 293, in main
     prof.runcall(engine.application.run)
   File "/usr/lib64/python2.7/hotshot/__init__.py", line 78, in runcall
     return self._prof.runcall(func, args, kw)
File "/usr/lib64/python2.7/site-packages/gi/types.py", line 113, in function
     return info.invoke(*args, **kwargs)
TypeError: run() takes exactly 2 arguments (1 given)

Should this be fixed or should I submit a patch removing the --profile option as it seems nobody is using it?

It's not really aimed at end users, but at developers. I just haven't run it since the conversion to gtk application 4-5 months ago, but it is still useful.

I'd be happy to take a patch to use optparse.SUPPRESS_HELP and drop it from
the man page (if it's even documented there).


Hi,cole
I found that on rhel 6,the parameter --profile is still in help,on rhel 7,no such issues.
# virt-manager -h
  --profile=FILE        Generate runtime performance profile stats
Yeah... when I said it was not in man pages nor in --help I was referring to upstream.

Best regards,

Leonardo Garcia

- Cole

_______________________________________________
virt-tools-list mailing list
virt-tools-list redhat com
https://www.redhat.com/mailman/listinfo/virt-tools-list



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]