[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-manager PATCH] Fix UUID generation according to RFC 4122



On 08/16/2013 08:53 AM, Martin Kletzander wrote:
> In commit 74aa8c8a, I somehow made an off-by-one error even though
> that code was almost copy-paste from libvirt's commit 396c4d34.
> ---
>  virtinst/util.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/virtinst/util.py b/virtinst/util.py
> index f1bc5c3..0ddf051 100644
> --- a/virtinst/util.py
> +++ b/virtinst/util.py
> @@ -378,8 +378,8 @@ def randomUUID(conn):
>          return "00000000-1111-2222-3333-444444444444"
> 
>      u = [random.randint(0, 255) for ignore in range(0, 16)]
> -    u[7] = (u[7] & 0x0F) | (4 << 4)
> -    u[9] = (u[9] & 0x3F) | (2 << 6)
> +    u[6] = (u[6] & 0x0F) | (4 << 4)
> +    u[8] = (u[8] & 0x3F) | (2 << 6)
>      return "-".join(["%02x" * 4, "%02x" * 2, "%02x" * 2, "%02x" * 2,
>                       "%02x" * 6]) % tuple(u)
> 

ACK

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]