[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCHv2 virt-viewer 02/10] kiosk: add app kiosk option, pass it down to window




----- Mensaje original -----
> On Fri, Aug 16, 2013 at 09:47:38PM +0200, Marc-André Lureau wrote:
> > +void
> > +virt_viewer_window_set_kiosk(VirtViewerWindow *self, gboolean enabled)
> > +{
> > +    if (self->priv->kiosk == enabled)
> > +        return;
> > +
> 
> Nit: I'd use !!enabled here..
> 
> > +    self->priv->kiosk = enabled;
> 
> and here to be 100% sure we only get 0 and 1 instead of 0 and !0.

I don't think that's necessary, and if we would want to catch such cases, I would rather add a g_warn_if_fail(enabled == !!enabled) or something..

> Christophe
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list redhat com
> https://www.redhat.com/mailman/listinfo/virt-tools-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]