[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCHv2 virt-viewer 10/10] kiosk: explicit resize window to fullscreen size



On Fri, Aug 16, 2013 at 09:47:46PM +0200, Marc-André Lureau wrote:
> Allow to run the client in kiosk mode with window-manager-less
> environment.
> 
> This was a conditionnal workaroud on win32. I am making it

conditional workaround

> non-conditionnal to make fullscreen work on non-wm environment. Hence

non-conditional

> I don't see the need to refer explicitely to the bug workaround, since
> it is no longer something that should be removed, even when gbo 652049

bgo

> is fixed.
> ---
>  src/virt-viewer-window.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
> index ac6b8fe..2b4747d 100644
> --- a/src/virt-viewer-window.c
> +++ b/src/virt-viewer-window.c
> @@ -480,13 +480,10 @@ virt_viewer_window_move_to_monitor(VirtViewerWindow *self)
>  
>      gdk_screen_get_monitor_geometry(gdk_screen_get_default(), n, &mon);
>      gtk_window_move(GTK_WINDOW(priv->window), mon.x, mon.y);
> -#ifdef G_OS_WIN32
> -    /* FIXME: on windows, fullscreen doesn't always hide the taskbar
> -       See https://bugzilla.gnome.org/show_bug.cgi?id=652049 */
> +
>      gtk_widget_set_size_request(GTK_WIDGET(priv->window),
>                                  mon.width,
>                                  mon.height);
> -#endif
>  }
>  
>  void
> @@ -509,9 +506,7 @@ virt_viewer_window_leave_fullscreen(VirtViewerWindow *self)
>      ViewAutoDrawer_SetActive(VIEW_AUTODRAWER(priv->layout), FALSE);
>      gtk_widget_show(menu);
>      gtk_widget_hide(priv->toolbar);
> -#ifdef G_OS_WIN32
>      gtk_widget_set_size_request(GTK_WIDGET(priv->window), -1, -1);
> -#endif
>      gtk_window_unfullscreen(GTK_WINDOW(priv->window));
>  
>  }
> -- 
> 1.8.3.rc1.49.g8d97506
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list redhat com
> https://www.redhat.com/mailman/listinfo/virt-tools-list

Attachment: pgpmQzz52dHsA.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]