[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-manager PATCH] Handle storage formats properly



On 08/21/2013 05:18 AM, Martin Kletzander wrote:
> This simple patch fixes three issues:
> 
>  1) We used only one list of storage formats.  However, we are able to
>     use some formats which we cannot create.  This patch adds a list
>     called 'no_create_formats' and moves such formats (currently only
>     one) into it and uses new parameter 'create' which describes
>     whether such formats should be removed or not.
> 
>  2) When creating new storage with the above fixed, we need to set the
>     combobox's text to "" in order not to change it to "raw".  This
>     was already done in reset_state(), but we need it also when
>     toggle_storage_select() happens and it doesn't hurt in
>     set_initial_state(), so I abstracted the implementation into
>     populate_disk_format_combo().
> 
>  3) It's a bit unrelated, but when bus of a domain disk gets changed
>     (in details.py), the address was not cleaned up properly ('target'
>     attribute was still kept), so I fixed up the VirtualDeviceAddress
>     as well.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=907289
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
> 
> Notes:
>     Sorry for not splitting these up in a separate patches, I hope this is
>     not needed in virt-manager for such simple case.  But feel free to
>     disagree, I'll just have to create one more bug to track the second
>     issue downstream.
> 

Nah, it's fine with me too. ACK, please push.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]