[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-viewer][PATCH 1/3] Don't redefine _FORTIFY_SOURCE macro



On 04.02.2013 15:45, Christophe Fergeau wrote:
> ACK to the 3 patches in this series.
> 
> Christophe
> 
> On Mon, Feb 04, 2013 at 03:30:43PM +0100, Michal Privoznik wrote:
>> If the _FORTIFY_SOURCE has been already defined, we unconditionally
>> redefine it, leaving us with warning/error thrown at compilation time.
>> ---
>>  acinclude.m4 | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/acinclude.m4 b/acinclude.m4
>> index 0c308bc..625413f 100644
>> --- a/acinclude.m4
>> +++ b/acinclude.m4
>> @@ -46,7 +46,7 @@ AC_DEFUN([VIRT_VIEWER_COMPILE_WARNINGS],[
>>  
>>      AH_VERBATIM([FORTIFY_SOURCE],
>>                  [/* Enable compile-time and run-time bounds-checking, and some warnings. */
>> -                 #if defined __OPTIMIZE__ && __OPTIMIZE__
>> +                 #if !defined _FORTIFY_SOURCE && defined __OPTIMIZE__ && __OPTIMIZE__
>>                   # define _FORTIFY_SOURCE 2
>>                   #endif
>>                  ])
>> -- 
>> 1.8.0.2
>>

Thanks, pushed.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]