[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-manager PATCH] Avoid getting AttributeError when handling libvirt error



On Mon, Feb 04, 2013 at 10:51:46PM +0100, Martin Kletzander wrote:
> My python libvirt module doesn't have VIR_ERR_* inside itself and
> according to some places in the code, this was already taken care of
> by using the 'getattr' with safe default.  However, there were still
> some places where this wasn't handled properly, so I tried to fixed it
> by adding getattr for these attributes wherever 'git grep VIR_ERR'
> found it.  While on that, I took the liberty of cleaning up some
> related lines that were too long.

This is a libvirt bug which virt-manager shouldn't work around.
The python bindings in the 1.0.2 release were broken.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]