[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 3/5] virt-viewer-display-spice: Pass proper x and y coordinates in windowed mode


Thanks for the review of these patches.

On 02/06/2013 03:11 PM, Marc-André Lureau wrote:

On Wed, Feb 6, 2013 at 2:39 PM, Hans de Goede <hdegoede redhat com> wrote:
This stops monitor order from the guest from being re-arranged in multi-
monitor setups when switching between fullscreen and windowed mode.

Isn't this the contrary of what you describe?: changing monitor
position when in window mode will rearrange them.

When a user in real life re-arranges his physical monitors, he will go
to gnome-display-properties (or something equivalent) there to make the
positioning there match the physical positioning of his monitors.

We do this for the user automatically when in fullscreen mode, this patch
just extends this to windowed mode too, which is much more consistent then
only doing it in fullscreen.

Anyways this has been discussed way too much already. When we discussed
this face to face last Friday you conceded that if I, Alon and Christophe
all 3 think this is the best way you would go along. So since you've no
code level objections against this patch, and since neither Alon nor
Christophe have indicated that they've changed their mind I'm just going
to push it.

I still disagree with this approach. We might want to re-align
monitors when we leave fullscreen, but not when the window is

If you change the patch to only update position when we leave
fullscreen, that would make more sense to me as the position of
monitor will not change later on.

Erm, no that will make things even more inconsistent, ie:
1) User prefers to have windows maximized rather then fullscreen, notices the
ltr order is wrong
2) User thinks lets try fullscreen, hey things are correct there
3) User leaves fullscreen
4) Huh now things are fine in windowed mode too ?

Really the more we make the different modes different / handle things specially
the more inconsistencies / corner cases we'll get.

Anyways as said this has been discussed way too much already, so I'm just going
to push this now.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]