[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer] win: add virt-viewer.msi build rule




----- Mensaje original -----
> On Tue, Feb 12, 2013 at 06:47:27PM +0100, Marc-André Lureau wrote:
> > On Tue, Feb 12, 2013 at 6:36 PM, Christophe Fergeau
> > <cfergeau redhat com> wrote:
> > > Looks much better, but one of my comments in the previous review
> > > is still
> > > pending.
> > 
> > About the info string "consistency"? Red Hat vs spice-space.org ?
> > 
> > I don't have better suggestion, feel free to suggest something
> > else.
> 
> I've already made a suggestion in the previous email...

I don't see how "virt-viewer maintainers" adds consistency.

> > I don't think that should prevent pushing this wxs file.
> 
> I'm perfectly fine with such an answer if you disagree with my
> suggestion, ignoring a review comment tends to delay the review
> process ;)

However, I just realized we have a http://virt-tools.org, which seems more appropriate for homepage and links than spice-space or virt-manager. We could "virt-tools.org" as manufacturer. I guess in theory it should be replaced with whoever built that msi. I will try to make it a wix variable overridable in command line.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]