[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 1/2] virt-viewer-display-spice: Pass proper x and y coordinates for monitors



On Fri, Jan 25, 2013 at 04:27:53PM +0100, Marc-André Lureau wrote:
> On Fri, Jan 25, 2013 at 4:23 PM, Hans de Goede <hdegoede redhat com> wrote:
> > < resend, Marc-André can I please get a reply to this? >
> >
> 
> I think that was my reply:
> 
> https://www.redhat.com/archives/virt-tools-list/2013-January/msg00047.html
> 
> 
> I strongly believe reordering VM/guest monitors based on relative
> floating windows position is wrong, but this is a matter of taste
> perhaps?, so that debate is endless. Only in fullscreen, where the
> notion of window identity is lost in favour of a notion of monitor we
> should do that.

I unfortunately haven't been able to test multi-screen with/without Hans's
patches (a bit of trouble getting multi-screen to work ;), however here is
my feeling about this.

First, I don't think it makes sense to have different behaviour between
fullscreen and windowed mode. *If* we do some magic reordering of windows
when going fullscreen, then we should do the same when virt-viewer windows
are moved around, or things get really inconsistent.

Another thing to consider is that with real hardware, if you move your
physical monitors around, then the way the screen are configured in your OS
will no longer match the actual order, which is totally expected.

Given that we are not in the physical world, we are able to detect that our
monitors are being moved around, in which case it probably makes things
nicer to make sure the monitor order matches what is seen by the OS. We
already are being smarter than the real world by letting the user change
the monitor physical size... (ie dynamic resolution).

Just my 2 cents, with the disclaimer that I need to play a bit with that to
get a better feel of it :)

Christophe

Attachment: pgp24ICxJ5rVW.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]