[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 0/3] Add auto USB redirection support for virt-manager

On 07/02/2013 02:34 AM, Cole Robinson wrote:
On 06/29/2013 01:08 AM, Guannan Ren wrote:
v3: Fix usbredir channel and checking race
     1/3, 2/3 acked by Leonardo

v2: add auto USB redirection support
     fixed error pointed out in v1

v1: add USB redirect menu item in console viewer

Add "Redirect USB device" option in console viewer
Initialize and embed UsbDeviceWidget object from SpiceClientGtk into
a dialog to let user choose available USB devices for redirection.
Throw an error message if USB connection failed.

Auo USB redirection is enabled by default.

There is race between creating usbredir channel and calling
has_usb_redirection() when initializing spice session like
happening on virt-viwer. So adding a new signal handler
on_details_menu_virtual_manager_activate() to recheck the
status of usbredir channel, set "Redirect USB device" option
sensitive if it is availiable.

Guannan Ren(3)
  [PATCH 1/3] add new "spice-disable-usbredir" option to disable autoredir feature
  [PATCH 2/3] error: helper function to embed customized widget into dialog
  [PATCH 3/3] details: Add auto USB redirection support in console viewer

  data/org.virt-manager.virt-manager.gschema.xml |  6 ++++++
  ui/vmm-details.ui                              | 10 ++++++++++
  virt-manager                                   |  5 +++++
  virtManager/config.py                          |  5 +++++
  virtManager/console.py                         | 81 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
  virtManager/details.py                         | 25 ++++++++++++++++++++++++-
  virtManager/domain.py                          |  7 +++++++
  virtManager/error.py                           | 14 +++++++++-----
  8 files changed, 145 insertions(+), 8 deletions(-)

Thanks Guannan, pushed now.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]