[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] --show-* options are broken



On 07/12/2013 01:03 PM, Leonardo Augusto Guimarães Garcia wrote:
> On 07/10/2013 06:48 PM, Cole Robinson wrote:
>> On 07/10/2013 04:58 PM, Cole Robinson wrote:
>>> On 07/10/2013 04:50 PM, Leonardo Augusto Guimarães Garcia wrote:
>>>> Hi Cole,
>>>>
>>>> Just FYI, commit 76887c9a3280da32d44d4276135a78d21dd12fe8 broke the --show-*
>>>> functionality.
>>>>
>>>> Traceback (most recent call last):
>>>>   File "/home/laggarcia/src/git/virt-manager/virtManager/engine.py", line 624,
>>>> in _show_vm_helper
>>>>     details = self._get_details_dialog(uri, uuid)
>>>>   File "/home/laggarcia/src/git/virt-manager/virtManager/engine.py", line 602,
>>>> in _get_details_dialog
>>>>     obj = vmmDetails(con.get_vm(uuid))
>>>>   File "/home/laggarcia/src/git/virt-manager/virtManager/connection.py", line
>>>> 625, in get_vm
>>>>     return self.vms[uuid]
>>>> KeyError: '927c2b5f-ae3a-4f5e-aaeb-4d7fb3846dce'
>>>>
>>>> Basically connections vms are not populated yet when trying to open the dialog.
>>>>
>>>> I am investigating the issue.
>>>>
>>>> Best regards,
>>>>
>>> Ah, sorry about that. Likely that we don't synchronously tick() any more when
>>> connecting to libvirt. We can probably hook to the connection on "vm-added"
>>> and then perform based on that, I'll poke at it.
>>>
>> Well, the attached patch fixes things. But there are some other issues I'm
>> just noticing here that stem from not showing the manager window on --show.
>> Like if something happens that causes us to never show the details window,
>> like wrong UUID or connection failure, then virt-manager doesn't exit. I don't
>> have time to look at these right now unfortunately.
> Your patch looks good. Could you please commit it to the main tree? I'll work
> on a better error checking routine that makes sure virt-manager exits
> gracefully if an error occurs and --show-* has been specified.
> 

Sounds good, pushed now.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]