[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 1/2] tests: fix xml for 'chap' authentication



On 07/25/2013 10:06 PM, Giuseppe Scrivano wrote:
> The change eb0d79c64be49950a42497c79709c1386bf588ce in libvirt changes
> the 'chap' authentication XML logic to work in the same way as 'ceph'.
> 
> This patch changes the XML layout for tests accordingly.
> ---
>  tests/testdriver.xml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/testdriver.xml b/tests/testdriver.xml
> index 614bd32..b956727 100644
> --- a/tests/testdriver.xml
> +++ b/tests/testdriver.xml
> @@ -1106,7 +1106,9 @@
>    <source>
>      <host name="iscsi.example.com"/>
>      <device path="demo-target"/>
> -    <auth type='chap' login='foobar' passwd='frobbar'/>
> +    <auth type='chap' username='foobar'>
> +      <secret uuid='2ec115d7-3a88-3ceb-bc12-0ac909a6fd87'/>
> +    </auth>
>    </source>
>    <target>
>      <path>/iscsi-pool</path>
> 

Hmm, I realize now that this will make the test suite fail with every libvirt
except latest git. Long term we can probably solve this by turning
testdriver.xml into a cheetah template and keying certain bits off the host
libvirt version, but for now I've dropped the <auth> entirely from the XML, no
unit tests depend on it.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]