[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-manager][PATCH] Remove unnecessary nested try block.



On 06/09/2013 03:40 PM, lagarcia linux vnet ibm com wrote:
> From: Leonardo Garcia <lagarcia br ibm com>
> 
> This nested block has been added by python-virtinst's commit
> 4a9664634dd5ae65ed92b59b1f1543633c7d8112, aparently without need.

python 2.4 doesn't support try...except...finally, hence the nested block. We
used to maintain 2.4 compat for RHEL5's sake, but that's irrelevant with the
current code base. I've pushed the patch now.

Also, not sure if this is intentionl, but your send-email patches don't have
your name in the From: field, just your email. I have this in my ~/.gitconfig

[sendemail]
    from = "Cole Robinson <crobinso redhat com>"


- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]