[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-manager][PATCH v3] Add delete VM option in console viewer.



On 06/17/2013 02:50 PM, Cole Robinson wrote:
Can we not just self.emit("action-vm-destroy") ? Then check the VM's state
afterwards, and if it's still running, just exit without showing an error.

Also, I'd prefer if we split this patch into two parts: first adding the
delete option to the details dialog and the code movement to engine.py, next
is this patch adding the new 'delete running' functionality. Should be pretty
simple since this change is mostly isolated to delete.py, but you'll need to
temporarily re-add the logic to not allow deleting a running VM. That way I
can apply the first patch while we work on this bit.
Thanks for the comments, Cole.

I'll work on your suggestions!

Best regards,

Leonardo Garcia


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]