[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-viewer PATCH] Use format string



Hi,
On Tue, Jun 25, 2013 at 12:55:59PM +0200, Christophe Fergeau wrote:
> On Tue, Jun 25, 2013 at 12:32:31PM +0200, Guido Günther wrote:
> > to fix
> > 
> > virt-viewer.c: In function 'virt_viewer_connect':
> > virt-viewer.c:686:13: error: format not a string literal and no format arguments [-Werror=format-security]
> >              g_warning(error->message);
> 
> Thanks, ACK

I don't have commit access so it'd be great if you could push this.
Cheers,
 -- Guido

> 
> Christophe
> 
> > ---
> >  src/virt-viewer.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/virt-viewer.c b/src/virt-viewer.c
> > index 5dea5b6..951a42b 100644
> > --- a/src/virt-viewer.c
> > +++ b/src/virt-viewer.c
> > @@ -683,7 +683,7 @@ virt_viewer_connect(VirtViewerApp *app)
> >  
> >      if (!virt_viewer_app_initial_connect(app, &error)) {
> >          if (error)
> > -            g_warning(error->message);
> > +            g_warning("%s", error->message);
> >          g_clear_error(&error);
> >          return -1;
> >      }
> > -- 
> > 1.8.3.1
> > 
> > _______________________________________________
> > virt-tools-list mailing list
> > virt-tools-list redhat com
> > https://www.redhat.com/mailman/listinfo/virt-tools-list



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]