[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-manager PATCH v2 0/4] Add support for TPM passthrough



On 06/27/2013 06:30 PM, Stefan Berger wrote:
> On 06/26/2013 07:48 PM, Cole Robinson wrote:
>> On 06/25/2013 09:45 PM, Stefan Berger wrote:
>>> Add support for the QEMU TPM passthrough device that is supported by libvirt:
>>>
>>> http://libvirt.org/formatdomain.html#elementsTpm
>>>
>>> I added the choice of the backend device even though only one backend
>>> type (passthrough) is supported right now, but we are working on getting
>>> another TPM backend into QEMU.
>>>
>>> Since only one device model (tpm-tis) is supported and we do not currently
>>> have plans to implemented for example a virtio model, I did not provide
>>> the choice for the device model.
>>>
>>> Changes:
>>> v1->v2: Followed Cole's suggestions
>>>
>> Thanks Stefan, pushed now.
> Thanks. I saw you modified the ui pages' XML a bit. Something in the details
> page must have change because now I only see a 'tpm' in the middle of the page
> rather than the details (passthrough device and device path). It looks like
> you moved the XML to another place.
> 

Argh, sorry about that, fixed upstream now.

I was moving the XML around to avoid warnings about 'tab renames' or something
like that. When you rebased the patches it put your new tab wedged between two
pre-existing tabs, and the out of order numbers made glade give a warning
despite it working fine.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]