[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 0/2] add USB redirection support in virt-manager



On 06/28/2013 11:31 AM, Guan Nan Ren wrote:
> The SpiceClientGtk.UsbDeviceWidget.new() still throw an error with none value.
> 

Indeed it looks like that second patch forgot to annotate
spice_usb_device_widget_new

Thanks,
Cole

> 
> ----- Original Message -----
> From: "Christophe Fergeau" <cfergeau redhat com>
> To: "Cole Robinson" <crobinso redhat com>
> Cc: virt-tools-list redhat com
> Sent: Friday, June 28, 2013 7:40:10 AM
> Subject: Re: [virt-tools-list] [PATCH 0/2] add USB redirection support in virt-manager
> 
> On Wed, Jun 26, 2013 at 01:31:48PM -0400, Cole Robinson wrote:
>>
>> And as mentioned yesterday, there is
>>
>> SpiceClientGtk.UsbDeviceWidget.new(self.session, None)
>> TypeError: Argument 1 does not allow None as a value
>>
>> So I'm guessing there's an (allow-none) annotation missing.
> 
> I just sent 2 patches to spice-devel which hopefully will fix that. Testing
> welcome as I only looked at the generated .gir to see if it looked correct.
> 
> http://lists.freedesktop.org/archives/spice-devel/2013-June/013797.html
> http://lists.freedesktop.org/archives/spice-devel/2013-June/013796.html
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]