[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCHv2 virt-viewer 0/4] Add version field in connection file



On Fri, Mar 08, 2013 at 03:15:33PM +0100, Marc-André Lureau wrote:
> Hi,
> 
> It might be worthwhile to check for required client version before
> establishing connection.
> 
> (I don't think it's worth to check for each capabilities and protocol
>  version, this would only explose the number of combinations. I think
>  it is better to assume that the min. requirement are checked during
>  configure - assuming the respective backend needed are compiled-in,
>  otherwise there is already a protocol required check error)

As with previous posting, IMHO, feature based checks are far better
than any version checks, precisely because of the assumption you
mention above - we should not be assuming people turn on every feature
at configure time.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]