[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-viewer] Remove gtk_window_present() call



On Wed, Mar 20, 2013 at 07:05:12PM +0100, Marc-André Lureau wrote:
> gtk_window_present() may forcefully call gdk_window_show(), which will
> call ShowWindow(). Although gdk call is not supposed to move the
> window if it's already visible, it does restore the window position on
> Vista+. For example, a snapped window will be moved back to its
> previous position.
> 
> Gtk+ ShowWindow() is currently using SW_SHOWNOACTIVATE, it should
> probably use SW_SHOWNA instead, but that didn't help anyway for a
> snapped window.
> 
> Since virt_viewer_window_show() already ensure the window is visible,
> I am not sure why gtk_window_present() is there in the first place, so
> just remove it.

Well virt_viewer_window_show() merely calls gtk_window_show()
which just unhides the window, but does not guarantee that the
user can actually see it. Per the docs gtk_window_present()
does more, ensuring the window is actually visible to the user

" Presents a window to the user. This may mean raising the
  window in the stacking order, deiconifying it, moving it
  to the current desktop, and/or giving it the keyboard focus,
  possibly dependent on the user's platform, window manager,
  and preferences. "

so I don't think we should be removing this

> https://bugzilla.redhat.com/show_bug.cgi?id=912713

Looking the problem description, I'm not convinced that the
gtk_window_present() is the root cause of the problem, but
rather just something that highlights a problem that exists
elsewhere

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]