[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 1/3] virt-viewer-window: Store the monitor locally



On Thu, Mar 21, 2013 at 04:20:34PM +0100, Hans de Goede wrote:
> Hi,
> 
> On 03/21/2013 03:16 PM, Christophe Fergeau wrote:
> >On Thu, Mar 21, 2013 at 01:36:59PM +0100, Hans de Goede wrote:
> >>With commit 81ed9d13 "virt_viewer_window_enter_fullscreen: Pass in monitor for
> >>fullscreen window" we need a monitor number to determine where to move
> >>the window when going fullscreen.
> >>
> >>Since the VirtViewerDisplay needs to know the fullscreen monitor number too,
> >>to determine the fullscreen size it was being stored there. But we don't
> >>always have a display, leading to errors like:
> >>
> >>(remote-viewer:7996): remote-viewer-CRITICAL **:
> >>virt_viewer_display_get_monitor: assertion `VIRT_VIEWER_IS_DISPLAY(self)'
> >>failed
> >>
> >>And to the monitor number not always being stored. This patchset fixes this
> >>by storing the monitor number inside VirtViewerWindow, and passing it to
> >>VirtViewerDisplay only when we've a display.
> >
> >Patch by itself seems ok, however this makes me wonder if all of this is
> >not papering over that we are doing trying to do too much with
> >VirtViewerWindow too early (ie before we have a display)?
> 
> No being able to have *a* window before the spice-display-connection is ready is
> by design, so that we've something to show the user while the connection is
> being established.

My previous answer was to be read as an ACK, but ... btw, this was not
explicit at all, so sending an explicit ACK.

Christophe

Attachment: pgp85jG2cSZ7f.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]