[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 4/6] IPv6 support: update the create network wizard



On 03/26/2013 07:05 AM, Gene Czarcinski wrote:
> This update includes changes to both the glade-3 ui and
> the releated python code (createnet.py).  There have
> been some significant changes made to both files for
> IPv6 support and some additional capabilities.
> 
> This update includes the fix so color will work in the
> network creation wizard.
> 
> The objective was to get the functionality implemented and
> some future effort may be needed to "improve" the
> python code.
> Signed-off-by: Gene Czarcinski <gene czarc net>
> ---
>  ui/vmm-create-net.ui     | 1518 ++++++++++++++++++++++++++++++++--------------
>  virtManager/createnet.py |  612 +++++++++++++++----
>  2 files changed, 1583 insertions(+), 547 deletions(-)
> 

A couple bits here:

- The color of the createnet header changed: it used to be black.
- There's horizontal separators added everywhere, they are spaced weirdly and
don't add anything. Please remove.
- Many vbox, like on the 'Name' screen, have a ton of empty entries now. This
doesn't affect the visible UI but is clutter when working in glade. Please
shrink them down to only the required sizes.
- Check the spacing here:
http://fedorapeople.org/~crobinso/virt-manager/create-net-spacing.png  . The
pre-existing elements don't expand, the added bits do. Also the DNS name field
extends across the whole UI. It should probably only be 20 chars long max.

Glade can be tricky for some of the subtle things, so make a best effort and
if there are still some things you can't get right I'll fix them up before
committing.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]