[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 2/6] IPv6 support: update gui python processing



On 03/26/2013 06:32 PM, Cole Robinson wrote:
Please squash this patch together with patch #1, the UI changes aren't much
useful in isolation.
Done

Also, for testing UI it's quite useful to use the libvirt test driver if you
haven't:

./virt-manager --connect test:///`pwd`/tests/testdriver.xml

The UI has a couple quirks:
- There's a separator between the IPv4 config and IPv6 config, I'd remove it.
- Please hide the entire IPv6 frame if the network doesn't have any IPv6 bits.
This is similar to how the interface details panel works. The testdriver
should help show all the interface details bits
I have done it but I am not sure I agree. If no IPv4 network address specified, then IPv4 frame is not displayed. If no IPv6 address is specified, then the IPv6 frame is not displayed. IPv4 forwarding moved to the basic frame and IPv6 forwarding was added. Also added was the DNS Domain Name if it is specified. Also, the Route-Via is now hidden if none is specified.

Be careful of what you ask for, you may get more than you wanted.
- If you have a suite of networks you are using to test the UI, please also
add them to tests/testdriver.xml so I can use them as well. It's as simple as
just copy+pasting the entire <network> XML into that file, in the same section
as the rest of the <network> instances.
I have about six network definitions that I will be adding to testdriver.xml as a separate patch file. These pretty much cover the various parameters.

I ran the test and something flashed by but I am not sure what that tells me.

Gene


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]