[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH] Do all display alignment in virt-viewer



On Thu, Oct 31, 2013 at 11:28 PM, Jonathon Jongsma <jjongsma redhat com> wrote:
> +    /* sort by distance from origin */

I wonder why it's sorted by distance (in spice-gtk too). Wouldn't a
sort by x (then y) be more intuitive?

> +    sorted_displays = g_new0(guint, ndisplays);
> +    for (i = 0; i < ndisplays; i++)
> +        sorted_displays[i] = i;
> +    g_qsort_with_data(sorted_displays, ndisplays, sizeof(guint), displays_cmp, displays);


Have you checked against RHEL6? qsort _with_data is not stable before
glib 2.32 (perhaps we could get the patch backported to rhel though)



-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]