[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[virt-tools-list] [PATCH virt-viewer] wixl: fix major upgrade not installing all files



When upgrading virt-viewer, a few files are missing. After repair, they
are all back again.  The reason for this is explained by the so called
Component Rules, that can be simplified by use "one file per component
and stable id". msitools stable component id was a bit buggy, and is now
fixed in upstream (since v0.93-18-ge395249)

Furthermore, although it's not mandatory for simple cases,
RemoveExistingProducts should be Schedule='afterInstallFinalize', see
also:

http://msdn.microsoft.com/en-us/library/aa371197%28v=vs.85%29.aspx
http://stackoverflow.com/questions/15138731/wix-major-upgrade-not-installing-all-files
---
 data/virt-viewer.wxs.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/data/virt-viewer.wxs.in b/data/virt-viewer.wxs.in
index 438f341..d5c2522 100644
--- a/data/virt-viewer.wxs.in
+++ b/data/virt-viewer.wxs.in
@@ -125,7 +125,7 @@
     </Feature>
 
     <InstallExecuteSequence>
-      <RemoveExistingProducts After="InstallValidate"/>
+      <RemoveExistingProducts After="InstallFinalize"/>
     </InstallExecuteSequence>
 
     <Icon Id="virt-viewer.ico" SourceFile="../icons/virt-viewer.ico"/>
-- 
1.8.3.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]