[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH virt-manager] details: show warning when guest inspection is not available



On 11/26/2013 10:23 AM, Giuseppe Scrivano wrote:
> Cole Robinson <crobinso redhat com> writes:
> 
>> On 11/25/2013 10:57 AM, Giuseppe Scrivano wrote:
>>> If libguestfs is not available and the guest cannot be inspected, show
>>> a warning instead and hide the "Operating System" and "Applications"
>>> frames.
>>>
>>> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=755869
>>>
>>
>> Right now libguestfs inspection typically only works if running virt-manager
>> as root which is certainly not common. So I think showing a warning in this
>> case is not the best idea since it will be there for the vast majority of
>> users. Please drop the warning.
> 
> Thanks, I'll drop this part.
> 
> 
>> Also, even if the python bindings are available, we may fail to inspect
>> anything at all because libguestfs can't access the disk image.. Please ensure
>> the UI is hidden in the case when inspection fails like this.
> 
> Wouldn't make sense to show these UI elements in case an error happens
> but introspection is present?  It will be clear to users that this
> feature is supported, but it has failed for other reasons.
> 

Yeah I guess showing the warning when inspection fails is the friendlier thing
to do, so I'm fine with that.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]