[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 5/5] virt-manager: Future-proof disk 'removable' check box



On 10/03/2013 09:39 PM, Fred A. Kemp wrote:
> From: "Fred A. Kemp" <anonym riseup net>
> 
> Currently only QEMU is supported so we only show the check box when
> it's used. The future-proofing is that we'll show it for an explicitly
> set non-default value, even for hypervisors we don't think support it.
> ---
>  virtManager/details.py |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/virtManager/details.py b/virtManager/details.py
> index 8ed4514..d11bec3 100644
> --- a/virtManager/details.py
> +++ b/virtManager/details.py
> @@ -2812,6 +2812,8 @@ class vmmDetails(vmmGObjectUI):
>                                           self.conn.is_test_conn()))
>          if removable is None:
>              removable = False
> +        else:
> +            can_set_removable = True
>  
>          if addr == "spapr-vio":
>              bus = "spapr-vscsi"
> 

Hmm, I intended to squash my suggested change to 4/5 into this patch, but I
inadvertently pushed it with 4/5. Either way, pushed this patch. Thanks for
the contribution.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]